Improve location information for some warnings/errors.

Improve location information for some warnings/errors.
Fixes issue 82
Committed: https://code.google.com/p/dart/source/detail?r=533

[Brian Wilkerson, 2011-10-18 21:01:39]

LGTM! Thanks for doing this! I'll let you know if we find any missed cases.

http://codereview.chromium.org/8348015/diff/3001/compiler/java/com/google/dar...
File
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
(right):

http://codereview.chromium.org/8348015/diff/3001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java:63:
new DartCompilationError(null, Location.NONE,
It's unfortunate that we don't have any context at this point, but I guess our
fallback approach (of associating the error with the library being compiled)
will be as good as we can get.

Do you know, off hand, whether we get another error generated if one of these
types is referenced in user code? I'm actually wondering whether it is
appropriate to create a compilation error here at all...

[John Lenz, 2011-10-18 21:07:13]

http://codereview.chromium.org/8348015/diff/3001/compiler/java/com/google/dar...
File
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
(right):

http://codereview.chromium.org/8348015/diff/3001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java:63:
new DartCompilationError(null, Location.NONE,
On 2011/10/18 21:01:39, Brian Wilkerson wrote:
> It's unfortunate that we don't have any context at this point, but I guess our
> fallback approach (of associating the error with the library being compiled)
> will be as good as we can get.
> 
> Do you know, off hand, whether we get another error generated if one of these
> types is referenced in user code? I'm actually wondering whether it is
> appropriate to create a compilation error here at all...

I believe this should only occur if there is some internal issue (the core lib
are not included, etc).  If so, I don't see it as user correctable.  I haven't
been paying much attention to the error policy, so I don't know if this is
"appropriate" or not.

[Brian Wilkerson, 2011-10-18 21:11:51]

> I believe this should only occur if there is some internal issue (the core lib
> are not included, etc).  If so, I don't see it as user correctable.  I haven't
> been paying much attention to the error policy, so I don't know if this is
> "appropriate" or not.

I would argue that we should not be generating compilation errors for problems
that are not caused by errors in the user's code and that the user cannot
correct. Should I create a separate issue for that?