Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java

Issue 8348015: Improve location information for some warnings/errors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/java/com/google/dart/compiler/parser/AbstractParser.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
===================================================================
--- compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java (revision 512)
+++ compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java (working copy)
@@ -60,7 +60,8 @@
if (element == null) {
Location location = null;
DartCompilationError error =
- new DartCompilationError(location, DartCompilerErrorCode.CANNOT_BE_RESOLVED, name);
+ new DartCompilationError(null, Location.NONE,
Brian Wilkerson 2011/10/18 21:01:39 It's unfortunate that we don't have any context at
John Lenz 2011/10/18 21:07:13 I believe this should only occur if there is some
+ DartCompilerErrorCode.CANNOT_BE_RESOLVED, name);
listener.compilationError(error);
return Types.newDynamicType();
}
« no previous file with comments | « compiler/java/com/google/dart/compiler/parser/AbstractParser.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698