Wrong condition caused repeated deoptimizations and performance degradation especially on Meteor.

Wrong condition caused repeated deoptimizations and performance degradation especially on Meteor.
Committed: https://code.google.com/p/dart/source/detail?r=546

[srdjan, 2011-10-19 08:27:26]

TBR

[ngeoffray, 2011-10-19 08:30:51]

http://codereview.chromium.org/8343024/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/8343024/diff/1/runtime/vm/code_generator.cc#ne...
runtime/vm/code_generator.cc:921: // was already deoptimized.
Shouldn't you also change the comment?

[srdjan, 2011-10-19 08:43:24]

http://codereview.chromium.org/8343024/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/8343024/diff/1/runtime/vm/code_generator.cc#ne...
runtime/vm/code_generator.cc:921: // was already deoptimized.
On 2011/10/19 08:30:51, ngeoffray wrote:
> Shouldn't you also change the comment?

The comment is correct, the code was wrong: now we skip if the function's code
is already deoptimized (is_optimized == false).

[ngeoffray, 2011-10-19 08:49:40]

LGTM

http://codereview.chromium.org/8343024/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/8343024/diff/1/runtime/vm/code_generator.cc#ne...
runtime/vm/code_generator.cc:921: // was already deoptimized.
On 2011/10/19 08:43:25, srdjan wrote:
> On 2011/10/19 08:30:51, ngeoffray wrote:
> > Shouldn't you also change the comment?
> 
> The comment is correct, the code was wrong: now we skip if the function's code
> is already deoptimized (is_optimized == false).

I see, thanks. Maybe a 'If the method is deoptimized, ...' at the beginning of
the comment would be clearer. Your call.