Wrong condition caused repeated deoptimizations and performance degradation especially on Meteor.

runtime/vm/code_generator.cc

Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc	(revision 545)
+++ runtime/vm/code_generator.cc	(working copy)
@@ -919,7 +919,7 @@
   // We have to skip the following otherwise the compiler will complain
   // when it attempts to install unoptimized code into a function that
   // was already deoptimized.

[ngeoffray, 2011/10/19 08:30:51]

Shouldn't you also change the comment?

[srdjan, 2011/10/19 08:43:25]

The comment is correct, the code was wrong: now we skip if the function's code
is already deoptimized (is_optimized == false).

[ngeoffray, 2011/10/19 08:49:40]

I see, thanks. Maybe a 'If the method is deoptimized, ...' at the beginning of
the comment would be clearer. Your call.

-  if (!Code::Handle(function.code()).is_optimized()) {
+  if (Code::Handle(function.code()).is_optimized()) {
     // Get unoptimized code. Compilation restores (reenables) the entry of
     // unoptimized code.
     Compiler::CompileFunction(function);