Issue 8341103: build.py will not accept --arch=dartc soon, so removing references and uses of --arch=dartc in th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341103: build.py will not accept --arch=dartc soon, so removing references and uses of --arch=dartc in th... (Closed)

Created:
9 years, 1 month ago by ngeoffray

Modified:
9 years, 1 month ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), zundel

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

build.py will not accept --arch=dartc soon, so removing references and uses of --arch=dartc in the repo. Committed: https://code.google.com/p/dart/source/detail?r=882

Patch Set 1 : '' #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -26 lines)			Patch
M	client/samples/total/bin/start-server	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	client/tools/buildbot_annotated_steps.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/scripts/build_dartc_for_perf_metrics	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/scripts/compiler_compare.sh	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/scripts/compiler_series_test.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/belay/buzzer/start-server	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	samples/chat/README	View	2 chunks	+1 line, -2 lines	2 comments	Download
M	tools/make_bundle.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/presubmit.sh	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/utils.py	View	1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM, but I must admit that I'm a bit hazy on the overall picture. I ...

9 years, 1 month ago (2011-10-28 10:35:18 UTC) #2

ngeoffray

9 years, 1 month ago (2011-10-28 10:39:05 UTC) #3

Thanks. Hopefully, we'll get something consistent soon.

http://codereview.chromium.org/8341103/diff/1001/samples/chat/README
File samples/chat/README (right):

http://codereview.chromium.org/8341103/diff/1001/samples/chat/README#newcode36
samples/chat/README:36: $ tools/build.py --arch=ia32 --mode=release
On 2011/10/28 10:35:18, kasperl wrote:
> Does this still build DartC?

Yes. It's building at the top-level, so it's building the VM and dartc.

Expand Messages | Collapse Messages