Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: tools/utils.py

Issue 8341103: build.py will not accept --arch=dartc soon, so removing references and uses of --arch=dartc in th... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« samples/chat/README ('K') | « tools/presubmit.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/utils.py
===================================================================
--- tools/utils.py (revision 881)
+++ tools/utils.py (working copy)
@@ -130,19 +130,18 @@
def GetBuildConf(mode, arch):
return GetBuildMode(mode) + "_" + arch
-# Temporary variables that we should remove once the buildbots build 'ia32'
-# instead of 'dartc'.
-RUN_FROM_TOP_DIR = os.path.basename(os.path.abspath(os.curdir)) == 'dart'
ARCH_GUESS = GuessArchitecture()
BASE_DIR = os.path.abspath(os.path.join(os.curdir, '..'))
-if RUN_FROM_TOP_DIR:
- BASE_DIR = os.path.abspath(os.curdir)
def GetBuildRoot(target_os, mode=None, arch=None):
- if arch == 'dartc' and RUN_FROM_TOP_DIR: arch = ARCH_GUESS
global BUILD_ROOT
if mode:
- return os.path.join(BUILD_ROOT[target_os], GetBuildConf(mode, arch))
+ path = os.path.join(BUILD_ROOT[target_os], GetBuildConf(mode, arch))
+ # TODO(ngeoffray): Remove this test once the testing infrastructure does not
+ # treat 'dartc' as an arch.
+ if not os.path.exists(path) and arch == 'dartc':
+ path = os.path.join(BUILD_ROOT[target_os], GetBuildConf(mode, ARCH_GUESS))
+ return path;
else:
return BUILD_ROOT[target_os]
« samples/chat/README ('K') | « tools/presubmit.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698