Issue 8341039: Clean up dartcombat tests to new API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341039: Clean up dartcombat tests to new API. (Closed)

Created:
9 years, 2 months ago by Bob Nystrom

Modified:
9 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Clean up dartcombat tests to new API. Committed: https://code.google.com/p/dart/source/detail?r=854

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -142 lines)			Patch
	M	client/testing/unittest/unittestsuite.dart	View		2 chunks	+15 lines, -61 lines	1 comment	Download
	M	client/tests/client/samples/dartcombat/dartcombat_tests.dart	View		4 chunks	+68 lines, -81 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

9 years, 2 months ago (2011-10-26 00:51:33 UTC) #2

lgtm

Awesome :)

http://codereview.chromium.org/8341039/diff/1/client/testing/unittest/unittes...
File client/testing/unittest/unittestsuite.dart (left):

http://codereview.chromium.org/8341039/diff/1/client/testing/unittest/unittes...
client/testing/unittest/unittestsuite.dart:100: void addTestSet(TestSet test) {
bye bye! :)

Expand Messages | Collapse Messages