Clean up dartcombat tests to new API.

client/testing/unittest/unittestsuite.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(rnystrom): This code is gradually moving from a Java/JUnit style to
 // something closer to JS/Jasmine. Eventually, the UnitTestSuite class can go
 // away completely (or become private to this library) and the only exposed API
 // will be group()/test()/expect(). Until then, both ways are supported, which
 // is why things look a bit weird in here.
 
@@ skipping 78 matching lines @@
   }
 
   /** Subclasses should override this method to register tests. */
   void setUpTestSuite() {}
 
   /** Enqueues a synchronous test. */
   void addTest(TestFunction body) {
     test(null, body);
   }
 
-  /** Adds the tests defined by the given TestSet to this suite. */
-  void addTestSet(TestSet test) {

[Siggi Cherem (dart-lang), 2011/10/26 00:51:33]

bye bye! :)

-    test._bindToSuite(this);
-    test.setup();
-  }
-
-  /** Adds the tests defined by the given TestSets to this suite. */
-  void addTestSets(Iterable<TestSet> tests) {
-    for (TestSet test in tests) {
-      addTestSet(test);
-    }
-  }
-
   /** Enqueues an asynchronous test that waits for [callbacks] callbacks. */
   void addAsyncTest(TestFunction body, int callbacks) {
     asyncTest(null, callbacks, body);
   }
 
   /** Runs all queued tests, one at a time. */
   void runTests() {
     window.dynamic/*TODO(5389254)*/.postMessage('unittest-suite-start', '*');
     // Isolate.bind makes sure the closure runs in the same isolate (i.e. this
     // one) where it has been created.
@@ skipping 239 matching lines @@
 
 /**
  * Wraps an value and provides an "==" operator that can be used to verify that
  * the value matches a given expectation.
  */
 class Expectation {
   final _value;
 
   Expectation(this._value);
 
-  /** Asserts that the value is equivalent to the given expected value. */
+  /** Asserts that the value is equivalent to [expected]. */
   void equals(expected) {
     Expect.equals(expected, _value);
   }
 
   /**
-   * Failure if the difference between expected and actual is greater than the
-   * given tolerance. If no tolerance is given, tolerance is assumed to be the
-   * value 4 significant digits smaller than the value given for expected.
+   * Asserts that the difference between [expected] and the value is within
+   * [tolerance]. If no tolerance is given, it is assumed to be the value 4
+   * significant digits smaller than the expected value.
    */
   void approxEquals(num expected,
       [num tolerance = null, String reason = null]) {
     Expect.approxEquals(expected, _value, tolerance: tolerance, reason: reason);
   }
 
-  /** Asserts that the value is null. */
+  /** Asserts that the value is [null]. */
   void isNull() {
     Expect.equals(null, _value);
   }
 
-  /** Asserts that the value is not null. */
+  /** Asserts that the value is not [null]. */
   void isNotNull() {
     Expect.notEquals(null, _value);
   }
 
-  /** Asserts that the value is true. */
+  /** Asserts that the value is [true]. */
   void isTrue() {
     Expect.equals(true, _value);
   }
 
-  /** Asserts that the value is null. */
+  /** Asserts that the value is [false]. */
   void isFalse() {
     Expect.equals(false, _value);
   }
 
-  /** Asserts that the value has the same elements as the given collection. */
+  /** Asserts that the value has the same elements as [expected]. */
   void equalsCollection(Collection expected) {
     Expect.listEquals(expected, _value);
   }
-}
 
-/**
- * A TestSet lets you break a test suite down into a collection of classes to
- * keep things manageable. It exposes the same interface as UnitTestSuite
- * (test(), group(), expect(), etc.) but defers to a parent suite that owns it.
- */
-class TestSet {
-  UnitTestSuite _currentSuite = null;
-
-  // TODO(rnystrom): Remove this when default constructors are supported.
-  TestSet();
-
-  void _bindToSuite(UnitTestSuite suite) {
-    _currentSuite = suite;
-  }
-
-  /** Override this to define the specifications for this test set. */
-  void setup() {
-    // Do nothing.
-  }
-
-  /** Enqueues a synchronous test. */
-  void addTest(TestFunction test) {
-    _currentSuite.addTest(test);
-  }
-
-  /** Adds the tests defined by the given TestSet to this suite. */
-  void addTestSet(TestSet test) {
-    _currentSuite.addTestSet(test);
-  }
-
-  /** Adds the tests defined by the given TestSets to this suite. */
-  void addTestSets(Iterable<TestSet> tests) {
-    _currentSuite.addTestSets(tests);
-  }
-
-  /** Enqueues an asynchronous test that waits for [callbacks] callbacks. */
-  void addAsyncTest(TestFunction test, int callbacks) {
-    _currentSuite.addAsyncTest(test, callbacks);
+  /**
+   * Checks that every element of [expected] is also in [actual], and that
+   * every element of [actual] is also in [expected].
+   */
+  void equalsSet(Iterable expected) {
+    Expect.setEquals(expected, _value);
   }
 }
 
 /** Summarizes information about a single test case. */
 class TestCase {
   /** Identifier for this test. */
   final id;
 
   /** A description of what the test is specifying. */
   final String description;
@@ skipping 64 matching lines @@
         </tr>""";
     if (stackTrace != null) {
       message +=
           "<tr><td></td><td colspan='2'><pre>${stackTrace}</pre></td></tr>";
     }
     fail = true;
   }
 }
 
 typedef void TestFunction();