Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 8297009: Get rid of "==" in Expectation. (Closed)

Created:
9 years, 2 months ago by Bob Nystrom
Modified:
9 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get rid of "==" in Expectation. Committed: https://code.google.com/p/dart/source/detail?r=462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -94 lines) Patch
M client/testing/unittest/unittestsuite.dart View 1 chunk +16 lines, -5 lines 0 comments Download
M client/tests/client/observable/AbstractObservableTests.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M client/tests/client/observable/ChangeEventTests.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M client/tests/client/observable/EventBatchTests.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M client/tests/client/observable/ObservableListTests.dart View 5 chunks +30 lines, -30 lines 0 comments Download
M client/tests/client/observable/ObservableTestSetBase.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M client/tests/client/observable/ObservableValueTests.dart View 1 chunk +12 lines, -12 lines 0 comments Download
M client/tests/client/view/ViewTests.dart View 11 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
Jim convinced me that overloading == for this was a little *too* clever, especially because ...
9 years, 2 months ago (2011-10-14 22:43:22 UTC) #1
mattsh
LGTM Do we still need the Expectation class at all now, i.e. just use Expect?
9 years, 2 months ago (2011-10-14 23:05:10 UTC) #2
Siggi Cherem (dart-lang)
lgtm
9 years, 2 months ago (2011-10-14 23:09:22 UTC) #3
Bob Nystrom
9 years, 2 months ago (2011-10-14 23:19:29 UTC) #4
On 2011/10/14 23:05:10, mattsh wrote:
> LGTM
> Do we still need the Expectation class at all now, i.e. just use Expect?

Yes, I think expect still gives you a nicer API:

expect(foo).equals(bar);
Expect.equals(bar, foo);

Not really any more terse now, but I think it still reads better.

Powered by Google App Engine
This is Rietveld 408576698