Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: client/tests/client/observable/ObservableValueTests.dart

Issue 8297009: Get rid of "==" in Expectation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/client/observable/ObservableTestSetBase.dart ('k') | client/tests/client/view/ViewTests.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tests/client/observable/ObservableValueTests.dart
diff --git a/client/tests/client/observable/ObservableValueTests.dart b/client/tests/client/observable/ObservableValueTests.dart
index 981af3f64b21edce5b962ccbc5d5b843714c9dfc..e5f7e247f35c070cc58b3e1b70eb2d469922e463 100644
--- a/client/tests/client/observable/ObservableValueTests.dart
+++ b/client/tests/client/observable/ObservableValueTests.dart
@@ -12,40 +12,40 @@ class ObservableValueTests extends ObservableTestSetBase {
}
void testObservableValue() {
- final value = new ObservableValue<String>("initial");
- expect(value.value) == "initial";
+ final value = new ObservableValue<String>('initial');
+ expect(value.value).equals('initial');
// Set value.
- value.value = "new";
- expect(value.value) == "new";
+ value.value = 'new';
+ expect(value.value).equals('new');
// Change event is sent when value is changed.
EventSummary result = null;
value.addChangeListener((summary) {
- expect(result) == null;
+ expect(result).isNull();
result = summary;
expect(result).isNotNull();
});
- value.value = "newer";
+ value.value = 'newer';
expect(result).isNotNull();
- expect(result.events.length) == 1;
+ expect(result.events.length).equals(1);
checkEvent(result.events[0],
- value, "value", null, ChangeEvent.UPDATE, "newer", "new");
+ value, 'value', null, ChangeEvent.UPDATE, 'newer', 'new');
}
void testObservableValueDoesNotRaiseEventIfUnchanged() {
- final value = new ObservableValue<String>("foo");
- expect(value.value) == "foo";
+ final value = new ObservableValue<String>('foo');
+ expect(value.value).equals('foo');
bool called = false;
value.addChangeListener((summary) { called = true; });
// Set it to the same value.
- value.value = "foo";
+ value.value = 'foo';
// Should not have gotten an event.
- expect(called) == false;
+ expect(called).equals(false);
}
}
« no previous file with comments | « client/tests/client/observable/ObservableTestSetBase.dart ('k') | client/tests/client/view/ViewTests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698