Issue 8271023: Set the source position on a DartFunction if an error is reported. (b/4337388)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8271023: Set the source position on a DartFunction if an error is reported. (b/4337388) (Closed)

Created:
9 years, 2 months ago by John Lenz

Modified:
9 years, 2 months ago

Reviewers:
jat

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Set the source position on a DartFunction if an error is reported. (b/4337388) Committed: https://code.google.com/p/dart/source/detail?r=419

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		10 chunks	+10 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jat

LGTM http://codereview.chromium.org/8271023/diff/1/compiler/java/com/google/dart/compiler/parser/DartParser.java File compiler/java/com/google/dart/compiler/parser/DartParser.java (right): http://codereview.chromium.org/8271023/diff/1/compiler/java/com/google/dart/compiler/parser/DartParser.java#newcode2060 compiler/java/com/google/dart/compiler/parser/DartParser.java:2060: reportError(doneWithoutConsuming(function), DartCompilerErrorCode.MISSING_FUNCTION_NAME); I think it would be better ...

9 years, 2 months ago (2011-10-14 00:10:39 UTC) #2

John Lenz

9 years, 2 months ago (2011-10-14 15:52:37 UTC) #3

http://codereview.chromium.org/8271023/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8271023/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2060:
reportError(doneWithoutConsuming(function),
DartCompilerErrorCode.MISSING_FUNCTION_NAME);
On 2011/10/14 00:10:39, jat wrote:
> I think it would be better to put this on the line where function is assigned,
> so it will always have the position information -- if the caller does it
again,
> it will overwrite it.

Done.

Expand Messages | Collapse Messages