Set the source position on a DartFunction if an error is reported. (b/4337388)

compiler/java/com/google/dart/compiler/parser/DartParser.java

Index: compiler/java/com/google/dart/compiler/parser/DartParser.java
===================================================================
--- compiler/java/com/google/dart/compiler/parser/DartParser.java	(revision 418)
+++ compiler/java/com/google/dart/compiler/parser/DartParser.java	(working copy)
@@ -183,7 +183,7 @@
   private DartParser(Source source, DartCompilerListener listener) throws IOException {
     this(source, source.getSourceReader(), listener);
   }
-  
+
   private DartParser(Source source,
                     Reader sourceReader,
                     DartCompilerListener listener) throws IOException {
@@ -274,7 +274,7 @@
 
   /**
    * A version of the parser which only parses the directives of a library.
-   * 
+   *
    * TODO(jbrosenberg): consider parsing the whole file here, in order to avoid
    * duplicate work.  Probably requires removing use of LibraryUnit's, etc.
    * Also, this minimal parse does have benefit in the incremental compilation
@@ -640,7 +640,7 @@
 
   /**
    * Parse a field or method, which may be inside a class or at the top level.
-   * 
+   *
    * <pre>
    * // This rule is organized in a way that may not be most readable, but
    * // gives the best error messages.
@@ -730,7 +730,7 @@
    *     | NEGATE
    *     ;
    * </pre>
-   * 
+   *
    * @param allowStatic true if the static modifier is allowed
    * @return a {@link DartNode} representing the grammar fragment above
    */
@@ -2057,7 +2057,7 @@
     DartBlock body = parseFunctionStatementBody(isDeclaration);
     DartFunction function = new DartFunction(params, body, returnType);
     if (isDeclaration && namePtr[0] == null) {
-      reportError(function, DartCompilerErrorCode.MISSING_FUNCTION_NAME);
+      reportError(doneWithoutConsuming(function), DartCompilerErrorCode.MISSING_FUNCTION_NAME);

[jat, 2011/10/14 00:10:39]

I think it would be better to put this on the line where function is assigned,
so it will always have the position information -- if the caller does it again,
it will overwrite it.

[John Lenz, 2011/10/14 15:52:37]

Done.

     }
     return function;
   }
@@ -2824,7 +2824,7 @@
    * <p>
    * Note that this is a crude heuristic that needs to be improved for better
    * error recovery.
-   * 
+   *
    * @return a {@link DartSyntheticErrorStatement}
    */
   private DartStatement parseErrorStatement() {
@@ -2879,7 +2879,7 @@
         break;
     }
 
-    while (true) { 
+    while (true) {
       switch (peek(0)) {
         case EOS:
           return;
@@ -2897,7 +2897,7 @@
             return;
           }
           break;
-     
+
         case LBRACE:
           ++braceCount;
           //$FALL-THROUGH$
@@ -2910,7 +2910,7 @@
 
   /**
    * Report an error without advancing past the next token.
-   * 
+   *
    * @param errCode the error code to report, which may take a string parameter
    *     containing the actual token found
    */
@@ -3183,7 +3183,7 @@
         done = true;
         done(null);
       } else {
-        if (peek(0) != Token.EOS) { 
+        if (peek(0) != Token.EOS) {
           members.add(parseDefaultMember(label));
         }
         expectCloseBrace();