Issue 8249007: Implement the full process interface for Windows

Issue 8249007: Implement the full process interface for Windows (Closed)

Created:
9 years, 2 months ago by Søren Gjesse

Modified:
9 years, 2 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Description

Implement the full process interface for Windows There are still a couple of TODOs in the code. R=ager@google.com Committed: https://code.google.com/p/dart/source/detail?r=389

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+334 lines, -37 lines)			Patch
M	bin/eventhandler_win.h	View		3 chunks	+11 lines, -5 lines	0 comments	Download
M	bin/eventhandler_win.cc	View		6 chunks	+30 lines, -7 lines	0 comments	Download
M	bin/process_impl.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	bin/process_win.cc	View	1	5 chunks	+285 lines, -15 lines	0 comments	Download
M	bin/socket_win.cc	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM when these comments have been addressed. http://codereview.chromium.org/8249007/diff/1/bin/process_win.cc File bin/process_win.cc (right): http://codereview.chromium.org/8249007/diff/1/bin/process_win.cc#newcode76 bin/process_win.cc:76: // Create ...

9 years, 2 months ago (2011-10-13 07:45:31 UTC) #2

Søren Gjesse

9 years, 2 months ago (2011-10-13 10:36:08 UTC) #3

http://codereview.chromium.org/8249007/diff/1/bin/process_win.cc
File bin/process_win.cc (right):

http://codereview.chromium.org/8249007/diff/1/bin/process_win.cc#newcode76
bin/process_win.cc:76: // Create a pipe for the communicating with a new
process. The handles array
On 2011/10/13 07:45:31, Mads Ager wrote:
> for the communicating -> for communicating

Done.

http://codereview.chromium.org/8249007/diff/1/bin/process_win.cc#newcode78
bin/process_win.cc:78: // argument (seen from the new process) either the read
or the write end of
On 2011/10/13 07:45:31, Mads Ager wrote:
> The parenthetical '(seen from the new process)' comment confused me. Maybe
just
> remove?

Done.

http://codereview.chromium.org/8249007/diff/1/bin/process_win.cc#newcode201
bin/process_win.cc:201: if (!CreateProcessPipe(stdin_handles, pipe_name, true))
goto cleanup;
On 2011/10/13 07:45:31, Mads Ager wrote:
> Let's create a cleanup method and call that and then return instead of all of
> these gotos.

Done.

Expand Messages | Collapse Messages