Fix named parameters handling of values that are falsy in JS.

Fix named parameters handling of values that are falsy in JS, also fixes issues with named parameters that whose "default" value should default to "null".
Committed: https://code.google.com/p/dart/source/detail?r=358

[jat, 2011-10-11 20:28:23]

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/backend/js/AbstractJsBackend.java
(right):

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/AbstractJsBackend.java:556:
return true;// false;
What is this comment for?

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/util/AstUtil.java (right):

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/util/AstUtil.java:78: public static
JsNameRef nameref(SourceInfo info, JsExpression qualifier, JsName prop) {
Since newNameRef is going away, I suggest either leaving the rename of
newNameRef->nameRef to a separate CL that does all of them, or do all of them
now.

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/util/AstUtil.java:220: public static
JsExpression in(SourceInfo src, JsExpression op1, JsExpression op2) {
op1 and op2 could have more useful names, perhaps key and map?

http://codereview.chromium.org/8232014/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/common/GenerateSourceMapTest.java
(right):

http://codereview.chromium.org/8232014/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/common/GenerateSourceMapTest.java:301:
return getResultForCompile(filename, sourceCode, part, backend,
Is there some reason for extracting the backend variable?  Or was this just for
debugging?

http://codereview.chromium.org/8232014/diff/1/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8232014/diff/1/tests/language/language.status#...
tests/language/language.status:85: NamedParametersPassingFalseTest: Fail # Bug
Do we have a bug number for this one?  Will it be addressed in a separate
change?

[jat, 2011-10-11 20:31:01]

LGTM

Please consider the other comments that weren't addressed in patch set 2, though
as they are just nits feel free to ignore them if you disagree.

[John Lenz, 2011-10-11 20:35:55]

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/backend/js/AbstractJsBackend.java
(right):

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/AbstractJsBackend.java:556:
return true;// false;
On 2011/10/11 20:28:23, jat wrote:
> What is this comment for?

Fixed, left over debugging. Should default to false

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/util/AstUtil.java (right):

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/util/AstUtil.java:78: public static
JsNameRef nameref(SourceInfo info, JsExpression qualifier, JsName prop) {
On 2011/10/11 20:28:23, jat wrote:
> Since newNameRef is going away, I suggest either leaving the rename of
> newNameRef->nameRef to a separate CL that does all of them, or do all of them
> now.

Done.

http://codereview.chromium.org/8232014/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/util/AstUtil.java:220: public static
JsExpression in(SourceInfo src, JsExpression op1, JsExpression op2) {
On 2011/10/11 20:28:23, jat wrote:
> op1 and op2 could have more useful names, perhaps key and map?

used "propName" and "obj"

http://codereview.chromium.org/8232014/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/common/GenerateSourceMapTest.java
(right):

http://codereview.chromium.org/8232014/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/common/GenerateSourceMapTest.java:301:
return getResultForCompile(filename, sourceCode, part, backend,
On 2011/10/11 20:28:23, jat wrote:
> Is there some reason for extracting the backend variable?  Or was this just
for
> debugging?

reverted.

http://codereview.chromium.org/8232014/diff/1/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8232014/diff/1/tests/language/language.status#...
tests/language/language.status:85: NamedParametersPassingFalseTest: Fail # Bug
On 2011/10/11 20:28:23, jat wrote:
> Do we have a bug number for this one?  Will it be addressed in a separate
> change?

Updated

[jat, 2011-10-11 20:43:26]

LGTM

[jat, 2011-10-11 22:33:09]

LGTM

http://codereview.chromium.org/8232014/diff/6003/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8232014/diff/6003/tests/language/language.stat...
tests/language/language.status:84: #NamedParametersPassingFalseTest: Fail #
Issue 67
Should this be removed?

[John Lenz, 2011-10-11 22:35:38]

http://codereview.chromium.org/8232014/diff/6003/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8232014/diff/6003/tests/language/language.stat...
tests/language/language.status:84: #NamedParametersPassingFalseTest: Fail #
Issue 67
On 2011/10/11 22:33:09, jat wrote:
> Should this be removed?

Done.