compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java - Issue 8232014: Fix named parameters handling of values that are falsy in JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java

Issue 8232014: Fix named parameters handling of values that are falsy in JS. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java ('k') | compiler/java/com/google/dart/compiler/util/AstUtil.java » ('j') | tests/language/language.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java

===================================================================

--- compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java (revision 350)

+++ compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java (working copy)

@@ -10,19 +10,11 @@

import com.google.dart.compiler.DartCompilerContext;

import com.google.dart.compiler.DartSource;

import com.google.dart.compiler.LibrarySource;

-import com.google.dart.compiler.ast.DartUnit;

import com.google.dart.compiler.ast.LibraryNode;

import com.google.dart.compiler.ast.LibraryUnit;

-import com.google.dart.compiler.backend.js.ast.JsBlock;

-import com.google.dart.compiler.backend.js.ast.JsProgram;

import com.google.dart.compiler.common.GenerateSourceMap;

import com.google.dart.compiler.metrics.CompilerMetrics;

-import com.google.dart.compiler.metrics.DartEventType;

-import com.google.dart.compiler.metrics.Tracer;

-import com.google.dart.compiler.metrics.Tracer.TraceEvent;

import com.google.dart.compiler.resolver.CoreTypeProvider;

-import com.google.dart.compiler.util.DefaultTextOutput;

-import com.google.dart.compiler.util.TextOutput;

import com.google.debugging.sourcemap.FilePosition;

import com.google.debugging.sourcemap.SourceMapSection;

@@ -31,7 +23,6 @@

import java.io.Writer;

import java.util.Collection;

import java.util.List;

-import java.util.Map;

/**

* A compiler backend that produces raw Javascript.