Issue 8231005: Fix wrong pointer arithmetic when extending the file descripter list in the eventhandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8231005: Fix wrong pointer arithmetic when extending the file descripter list in the eventhandler (Closed)

Created:
9 years, 2 months ago by Søren Gjesse

Modified:
9 years, 2 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fix wrong pointer arithmetic when extending the file descripter list in the eventhandler This caused random crashes due to memory corruption when the file descripter list in the eventhandler needed to be extended. R=ager@google.com BUG=none TEST=tests/dart/src/SocketManyConnectionsTest.dart Committed: https://code.google.com/p/dart/source/detail?r=331

Patch Set 1 #

Patch Set 2 : Fixed comment in test case #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -2 lines)			Patch
M	runtime/bin/eventhandler_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	runtime/tests/dart/src/SocketManyConnectionsTest.dart	View	1	1 chunk	+114 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages