runtime/bin/eventhandler_macos.cc - Issue 8231005: Fix wrong pointer arithmetic when extending the file descripter list in the eventhandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/eventhandler_macos.cc

Issue 8231005: Fix wrong pointer arithmetic when extending the file descripter list in the eventhandler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixed comment in test case Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/eventhandler_macos.cc

diff --git a/runtime/bin/eventhandler_macos.cc b/runtime/bin/eventhandler_macos.cc

index 45ea418cf4634e02ca8ae68085ad21eed549ee93..7d8d04bbb0385ba1c5d47fb20fbabf9223ac9848 100644

--- a/runtime/bin/eventhandler_macos.cc

+++ b/runtime/bin/eventhandler_macos.cc

@@ -71,7 +71,7 @@ void EventHandlerImplementation::SetPort(intptr_t fd,

new_port_map_bytes));

ASSERT(port_map_ != NULL);

size_t port_map_bytes = port_map_size_ * sizeof(PortData);

- memset(port_map_ + port_map_bytes,

+ memset(port_map_ + port_map_size_,

new_port_map_bytes - port_map_bytes);

port_map_size_ = new_port_map_size;

« no previous file with comments | « runtime/bin/eventhandler_linux.cc ('k') | runtime/tests/dart/src/SocketManyConnectionsTest.dart » ('j') | no next file with comments »