Issue 8220015: get_drt.py: show warning, but do not fail if we can't download DumpRenderTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8220015: get_drt.py: show warning, but do not fail if we can't download DumpRenderTree (Closed)

Created:
9 years, 2 months ago by Siggi Cherem (dart-lang)

Modified:
9 years, 2 months ago

Reviewers:
vsm, dgrove, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

get_drt.py: show warning, but do not fail if we can't download DumpRenderTree Committed: https://code.google.com/p/dart/source/detail?r=318

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	tools/get_drt.py	View		2 chunks	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years, 2 months ago (2011-10-10 22:18:27 UTC) #2

lgtm

http://codereview.chromium.org/8220015/diff/1/tools/get_drt.py
File tools/get_drt.py (right):

http://codereview.chromium.org/8220015/diff/1/tools/get_drt.py#newcode124
tools/get_drt.py:124: print "Couldn't download DumpRenderTree: %s\n%s" %
(pattern, str(out))
nit: you shouldn't need str() here, %s will do that

Expand Messages | Collapse Messages