Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: tools/get_drt.py

Issue 8220015: get_drt.py: show warning, but do not fail if we can't download DumpRenderTree (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/get_drt.py
diff --git a/tools/get_drt.py b/tools/get_drt.py
index 75bff088b4c5d0768ad4d72f30a9caacd898f4bc..bb743fc8d51153b33e6b202dc49f4ff890d20366 100755
--- a/tools/get_drt.py
+++ b/tools/get_drt.py
@@ -30,7 +30,7 @@ DRT_DARTIUM_LATEST_PATTERN = (
'gs://dartium-archive/latest/dartium-%(osname)s-inc-*.zip')
DRT_DARTIUM_PERMANENT_PREFIX = 'gs://dartium-archive/dartium-%(osname)s-inc'
DRT_CHROMIUM_LATEST_PATTERN = (
- 'gs://dart-dump-render-tree/latest/chromium-%(osname)s-103752.zip')
+ 'gs://dart-dump-render-tree/latest/chromium-%(osname)s-*.zip')
sys.path.append(GSUTIL_DIR + '/boto')
import boto
@@ -121,8 +121,10 @@ def main():
if result == 0:
latest = out.split()[-1]
else:
- raise Exception("Couldn't retrieve DumpRenderTree: %s\n%s" % (
- pattern, str(out)))
+ print "Couldn't download DumpRenderTree: %s\n%s" % (pattern, str(out))
Jennifer Messerly 2011/10/10 22:18:27 nit: you shouldn't need str() here, %s will do tha
+ if not os.path.exists(VERSION):
+ print "Tests using arch=chromium will not work. Please try again later."
+ return 0
# Check if we need to update the file
if os.path.exists(VERSION):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698