Remove the ability to compile without logging and profiling

Remove the ability to compile without logging and profiling

The preprocessor defines ENABLE_LOGGING_AND_PROFILING and ENABLE_VMSTATE_TRACKING has been removed as these where required to be turned on for Crankshaft to work. To re-enable reducing the binary size by leaving out heap and CPU profiler a new set of defines needs to be created.

R=ager@chromium.org

BUG=v8:1271
TEST=all

Committed: http://code.google.com/p/v8/source/detail?r=8622

[mnaganov (inactive), 2011-07-13 08:00:30]

On 2011/07/13 07:26:12, Søren Gjesse wrote:

Great job!

I was thinking about separating logging from profiling and leaving conditionals
for it.  Have you considered this?

BTW, this is tracked by http://code.google.com/p/v8/issues/detail?id=1271

[Søren Thygesen Gjesse, 2011-07-13 08:41:24]

On 2011/07/13 08:00:30, Mikhail Naganov (Chromium) wrote:
> On 2011/07/13 07:26:12, Søren Gjesse wrote:
> 
> Great job!
> 
> I was thinking about separating logging from profiling and leaving
conditionals
> for it.  Have you considered this?
> 
> BTW, this is tracked by http://code.google.com/p/v8/issues/detail?id=1271

I think we might want add new conditionals for leaving out e.g. logging,
especially for space constraint devices. However starting out by removing what
we have instead of patching it seems like the cleanest approach.

[Mads Ager (chromium), 2011-07-13 08:50:28]

LGTM!

http://codereview.chromium.org/7350014/diff/2001/SConstruct
File SConstruct (right):

http://codereview.chromium.org/7350014/diff/2001/SConstruct#newcode66
SConstruct:66: 'protectheap:on': {
Ooop. My mistake. I removed all usages of the ENABLE_HEAP_PROTECTION define.
Please remove this option.

[mnaganov (inactive), 2011-07-13 09:57:31]

On 2011/07/13 08:50:28, Mads Ager wrote:
> LGTM!
> 
> http://codereview.chromium.org/7350014/diff/2001/SConstruct
> File SConstruct (right):
> 
> http://codereview.chromium.org/7350014/diff/2001/SConstruct#newcode66
> SConstruct:66: 'protectheap:on': {
> Ooop. My mistake. I removed all usages of the ENABLE_HEAP_PROTECTION define.
> Please remove this option.

It looks like we somehow missed some conditionals in tests. I'll fix that.

[Søren Thygesen Gjesse, 2011-07-13 10:00:55]

http://codereview.chromium.org/7350014/diff/2001/SConstruct
File SConstruct (right):

http://codereview.chromium.org/7350014/diff/2001/SConstruct#newcode66
SConstruct:66: 'protectheap:on': {
On 2011/07/13 08:50:28, Mads Ager wrote:
> Ooop. My mistake. I removed all usages of the ENABLE_HEAP_PROTECTION define.
> Please remove this option.

Done.