src/SConscript - Issue 7350014: Remove the ability to compile without logging and profiling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/SConscript

Issue 7350014: Remove the ability to compile without logging and profiling (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed review comments Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/SConscript

diff --git a/src/SConscript b/src/SConscript

index 9d1d3a20f58e1072426ef0eec098d31ccf4fc9e1..6b3059aea60dbab374b1d636f76c0d09ad4271d8 100755

--- a/src/SConscript

+++ b/src/SConscript

@@ -313,10 +313,7 @@ def ConfigureObjectFiles():

env.Replace(**context.flags['v8'])

context.ApplyEnvOverrides(env)

env['BUILDERS']['JS2C'] = Builder(action=js2c.JS2C)

- if 'ENABLE_LOGGING_AND_PROFILING' in env['CPPDEFINES']:

- env['BUILDERS']['Snapshot'] = Builder(action='$SOURCE $TARGET --logfile "$LOGFILE" --log-snapshot-positions')

- else:

- env['BUILDERS']['Snapshot'] = Builder(action='$SOURCE $TARGET')

+ env['BUILDERS']['Snapshot'] = Builder(action='$SOURCE $TARGET --logfile "$LOGFILE" --log-snapshot-positions')

def BuildJS2CEnv(type):

js2c_env = { 'TYPE': type, 'COMPRESSION': 'off' }

« no previous file with comments | « SConstruct ('k') | src/api.cc » ('j') | no next file with comments »