Issue 7212027: Fix debug break on binary boolean operators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7212027: Fix debug break on binary boolean operators (Closed)

Created:
9 years, 5 months ago by Søren Thygesen Gjesse

Modified:
9 years, 5 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix debug break on binary boolean operators The syntax checker finding breakable statements did not take into account that the right hand side of a boolean binary opration might never get evaluated. R=svenpanne@chromium.org BUG=v8:1523 TEST=test/mjsunit/regress/regress-1523.js Committed: http://code.google.com/p/v8/source/detail?r=8544

Patch Set 1 #

Patch Set 2 : Chenge test to work with --stress-opt #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -1 line)			Patch
	M	src/full-codegen.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-1523.js	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages