Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: src/full-codegen.cc

Issue 7212027: Fix debug break on binary boolean operators (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Chenge test to work with --stress-opt Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1523.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 } 235 }
236 236
237 237
238 void BreakableStatementChecker::VisitCountOperation(CountOperation* expr) { 238 void BreakableStatementChecker::VisitCountOperation(CountOperation* expr) {
239 Visit(expr->expression()); 239 Visit(expr->expression());
240 } 240 }
241 241
242 242
243 void BreakableStatementChecker::VisitBinaryOperation(BinaryOperation* expr) { 243 void BreakableStatementChecker::VisitBinaryOperation(BinaryOperation* expr) {
244 Visit(expr->left()); 244 Visit(expr->left());
245 Visit(expr->right()); 245 if (expr->op() != Token::AND &&
246 expr->op() != Token::OR) {
247 Visit(expr->right());
248 }
246 } 249 }
247 250
248 251
249 void BreakableStatementChecker::VisitCompareToNull(CompareToNull* expr) { 252 void BreakableStatementChecker::VisitCompareToNull(CompareToNull* expr) {
250 Visit(expr->expression()); 253 Visit(expr->expression());
251 } 254 }
252 255
253 256
254 void BreakableStatementChecker::VisitCompareOperation(CompareOperation* expr) { 257 void BreakableStatementChecker::VisitCompareOperation(CompareOperation* expr) {
255 Visit(expr->left()); 258 Visit(expr->left());
(...skipping 1057 matching lines...) Expand 10 before | Expand all | Expand 10 after
1313 } 1316 }
1314 1317
1315 return false; 1318 return false;
1316 } 1319 }
1317 1320
1318 1321
1319 #undef __ 1322 #undef __
1320 1323
1321 1324
1322 } } // namespace v8::internal 1325 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1523.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698