Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 7034008: Submit code-stubs-mips.cc. (Closed)

Created:
9 years, 7 months ago by Paul Lind
Modified:
9 years, 7 months ago
CC:
v8-dev
Base URL:
http://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

Submit code-stubs-mips.cc. This submission required a small change to arch-indep code to declare code stub DirectCEntry for mips. It also required updates to macro-assembler-mips.cc & h and frames-mips.h. I also made a small change to frames-mips.cc. This code submission will compile, but is not testable until the majority of the mips port is in place. It has been tested externally. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6342 lines, -229 lines) Patch
M src/code-stubs.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 2 chunks +29 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 30 chunks +5890 lines, -98 lines 0 comments Download
M src/mips/frames-mips.h View 1 chunk +10 lines, -8 lines 0 comments Download
M src/mips/frames-mips.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 5 chunks +48 lines, -13 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 9 chunks +362 lines, -96 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 7 months ago (2011-05-16 06:02:49 UTC) #1
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-16 08:38:08 UTC) #2
LGTM

I will commit it.

Powered by Google App Engine
This is Rietveld 408576698