Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 6904126: ARM: Enhance the hardfloat support (Closed)

Created:
9 years, 7 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Karl Klose
CC:
v8-dev
Visibility:
Public.

Description

ARM: Enhance the hardfloat support The "simple" function with inline assembly for detecting hardfloat have been changed to handle compiling without VFP and with thumb. The SCons setting for the float abi now follows then naming used by the GCC -mfloat-abi and soft has been added. R=karlklose@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7725

Patch Set 1 #

Patch Set 2 : Corrected option name #

Patch Set 3 : Addressed review comments #

Patch Set 4 : Fix #

Patch Set 5 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -13 lines) Patch
M SConstruct View 1 2 3 4 5 chunks +27 lines, -9 lines 0 comments Download
M src/platform-linux.cc View 1 2 2 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 7 months ago (2011-04-29 11:24:32 UTC) #1
Karl Klose
9 years, 7 months ago (2011-04-29 11:29:12 UTC) #2
LGTM. 

Please update the year in the copyright header.

Powered by Google App Engine
This is Rietveld 408576698