Issue 6822025: ARM: Remove support for ABI prior to EABI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6822025: ARM: Remove support for ABI prior to EABI (Closed)

Created:
9 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Remove support for ABI prior to EABI The support for the old ABI is known to be broken and has been deprecated for some time now. Removed the instructions for loading and storing co-processor registers as they where only used to support the old ABI. R=karlklose@chromium.org BUG=v8:1316 TEST= Committed: http://code.google.com/p/v8/source/detail?r=7565

Patch Set 1 #

Patch Set 2 : After svn rebase #

Total comments: 2

Patch Set 3 : Review comments addresses #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -177 lines)			Patch
M	src/arm/assembler-arm.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View		1 chunk	+0 lines, -39 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 2	3 chunks	+5 lines, -25 lines	0 comments	Download
M	src/arm/constants-arm.h	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/arm/cpu-arm.cc	View		1 chunk	+26 lines, -55 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View		2 chunks	+0 lines, -10 lines	0 comments	Download
M	src/conversions-inl.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	src/v8.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

LGTM. http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc#newcode951 src/arm/code-stubs-arm.cc:951: // registers 0 and 1. r0 and r1 ...

9 years, 8 months ago (2011-04-11 08:48:02 UTC) #2

Søren Thygesen Gjesse

9 years, 8 months ago (2011-04-11 09:04:10 UTC) #3

http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc#newc...
src/arm/code-stubs-arm.cc:951: // registers 0 and 1.
On 2011/04/11 08:48:02, Karl Klose wrote:
> r0 and r1 instead of registers 0 and 1? Also below.

Done.

Expand Messages | Collapse Messages