Improve modulo operation in lithium on IA32.

Improve modulo operation in lithium on IA32.
Implement fast paths for the special cases like PowerOfTwo divisors
and the dividend being smaller than the divisor (non-negative).

BUG=v8:1314
Committed: http://code.google.com/p/v8/source/detail?r=7704

[Søren Thygesen Gjesse, 2011-04-27 14:11:43]

LGTM with comment addressed.

How about porting to x64 as well?

http://codereview.chromium.org/6816049/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6816049/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:798: NearLabel done, remainder_eq_dividend,
slow, do_subtraction, both_positive;
Please set up Register variables for left as well:

Register left = ToRegister(instr->InputAt(0));

And use it below instead of eax it more readable.

[yuqiang.xian, 2011-04-28 03:23:20]

Thanks for the comments.
Comments are addressed in the new patch.

I'll submit another patch to do the x64 porting.

On 2011/04/27 14:11:43, Søren Gjesse wrote:
> LGTM with comment addressed.
> 
> How about porting to x64 as well?
> 
> http://codereview.chromium.org/6816049/diff/1/src/ia32/lithium-codegen-ia32.cc
> File src/ia32/lithium-codegen-ia32.cc (right):
> 
>
http://codereview.chromium.org/6816049/diff/1/src/ia32/lithium-codegen-ia32.c...
> src/ia32/lithium-codegen-ia32.cc:798: NearLabel done, remainder_eq_dividend,
> slow, do_subtraction, both_positive;
> Please set up Register variables for left as well:
> 
> Register left = ToRegister(instr->InputAt(0));
> 
> And use it below instead of eax it more readable.

[Søren Thygesen Gjesse, 2011-04-28 14:50:38]

LGTM

[Søren Thygesen Gjesse, 2011-04-28 15:00:02]

On 2011/04/28 14:50:38, Søren Gjesse wrote:
> LGTM

Committed - I added you to the AUTHORS file as well. Thank you for the patch.