Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 6759052: Fix pc offset calculation for stack traces (Closed)

Created:
9 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix pc offset calculation for stack traces Use the correct address of the code object to calculate the offset from the code object start to a pc for an optimized frame. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/frames.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 8 months ago (2011-04-01 09:43:16 UTC) #1
fschneider
9 years, 8 months ago (2011-04-01 10:28:07 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698