Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/frames.h

Issue 6759052: Fix pc offset calculation for stack traces (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 int offset, 423 int offset,
424 bool is_constructor) 424 bool is_constructor)
425 : receiver_(receiver), 425 : receiver_(receiver),
426 function_(function), 426 function_(function),
427 code_(code), 427 code_(code),
428 offset_(offset), 428 offset_(offset),
429 is_constructor_(is_constructor) { } 429 is_constructor_(is_constructor) { }
430 Handle<Object> receiver() { return receiver_; } 430 Handle<Object> receiver() { return receiver_; }
431 Handle<JSFunction> function() { return function_; } 431 Handle<JSFunction> function() { return function_; }
432 Handle<Code> code() { return code_; } 432 Handle<Code> code() { return code_; }
433 Address pc() { return reinterpret_cast<Address>(*code_) + offset_; } 433 Address pc() { return code_->address() + offset_; }
434 int offset() { return offset_; } 434 int offset() { return offset_; }
435 bool is_constructor() { return is_constructor_; } 435 bool is_constructor() { return is_constructor_; }
436 436
437 void Print(); 437 void Print();
438 438
439 private: 439 private:
440 Handle<Object> receiver_; 440 Handle<Object> receiver_;
441 Handle<JSFunction> function_; 441 Handle<JSFunction> function_;
442 Handle<Code> code_; 442 Handle<Code> code_;
443 int offset_; 443 int offset_;
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 }; 828 };
829 829
830 830
831 // Reads all frames on the current stack and copies them into the current 831 // Reads all frames on the current stack and copies them into the current
832 // zone memory. 832 // zone memory.
833 Vector<StackFrame*> CreateStackMap(); 833 Vector<StackFrame*> CreateStackMap();
834 834
835 } } // namespace v8::internal 835 } } // namespace v8::internal
836 836
837 #endif // V8_FRAMES_H_ 837 #endif // V8_FRAMES_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698