Add initial sketch to shill repository

Add initial sketch to shill repository

BUG=chromium-os:12066
TEST=command-line

Change-Id: If1d01bf78fca80de4cc8a26e096e1967293d9738

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=75897df

[Chris Masone, 2011-03-10 18:43:36]

On 2011/02/23 22:10:24, Paul Stewart wrote:

looks good at a high level.  Some comments about naming and stuff.

[Chris Masone, 2011-03-10 18:44:15]

http://codereview.chromium.org/6575006/diff/10001/dbus_control_int.h
File dbus_control_int.h (right):

http://codereview.chromium.org/6575006/diff/10001/dbus_control_int.h#newcode27
dbus_control_int.h:27: class DBusManagerProxy : protected DBusProxy, public
ManagerProxyInterface {
I might name these things differently to make it clear that the purpose of this
class is to do Manager things, and that it enacts them by proxying the calls via
DBus.

ManagerDBusProxy?  DBusManagerProxy just reads like the most important thing
about the class is the DBus-ness.  Or maybe that it's a DBusManager that happens
to Proxy calls or something.

http://codereview.chromium.org/6575006/diff/10001/shill_event.h
File shill_event.h (right):

http://codereview.chromium.org/6575006/diff/10001/shill_event.h#newcode16
shill_event.h:16: class Callback {
I won't push too hard, but Chrome does have a notion of event loops and tasks
you can schedule/post to them.  The Chrome main message loop == the glib main
loop, even.  It gets a little awkward if you want to use both the chrome and
glib mechanisms for doing event handling, but it can be done.  If you're really
just doing task posting and handling dbus, it works pretty good.  If it doesn't
do stuff you need, though, don't worry about it.

[Sam Leffler, 2011-03-11 01:30:42]

I think you+I need to talk for me to understand how the classes are organized. 
It looks like you're constructing a general framework with mix-ins for for the
specific control interface (with DBus the only example). I'm guessing the intent
is to support multiple control interfaces simultaneously (e.g. DBus for legacy
connection, protobufs for new stuff, etc.) but there aren't any comments to
help.

http://codereview.chromium.org/6575006/diff/10001/control_interface.h
File control_interface.h (right):

http://codereview.chromium.org/6575006/diff/10001/control_interface.h#newcode35
control_interface.h:35: // These are the functions that a Manager proxy must
support
s/Manager/Service/

http://codereview.chromium.org/6575006/diff/10001/control_interface.h#newcode42
control_interface.h:42: // These are the functions that a Manager proxy must
support
s/Manager/Device/

http://codereview.chromium.org/6575006/diff/10001/shill_event.h
File shill_event.h (right):

http://codereview.chromium.org/6575006/diff/10001/shill_event.h#newcode16
shill_event.h:16: class Callback {
I haven't looked at chrome's event + task support but I'd echo this comment--the
more existing code you can re-use the easier it should be to get people ramped
up on shill.

[Paul Stewart, 2011-04-27 00:08:14]

I think I've addressed most issues, except for throwing away Callback for
something built-in.  Is there anything else before it's good enough for a first
commit to the repository so other people can start playing?

[Chris Masone, 2011-04-27 00:29:51]

LGTM :-)

On 2011/04/27 00:08:14, Paul Stewart wrote:
> I think I've addressed most issues, except for throwing away Callback for
> something built-in.  Is there anything else before it's good enough for a
first
> commit to the repository so other people can start playing?