DOMUI: Refactor the new overlay style and apply it to all overlays.

DOMUI: Refactor the new overlay style and apply it to all overlays.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72356

[stuartmorgan, 2011-01-22 00:48:05]

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/add_startup_page_overlay.html (right):

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/add_startup_page_overlay.html:11: <span
class="action-area-left"></span>
The empty element shouldn't be necessary everywhere if you add
box-direction:reverse to action-area

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/add_startup_page_overlay.html:12: <span>
Span is an inline element; this should be div.

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_address_overlay.html:64: <div
class="table">
I know this is pre-existing but... why have we completely re-invented all the
table elements as classes? If this is conceptually a table, why not use a table?

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/language_add_language_overlay.html
(right):

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/language_add_language_overlay.html:10: <div
id="add-language-content-area" class="content-area">
Instead of adding the id just for CSS, make the rule:
#add-language-overlay-page .content-area

[James Hawkins, 2011-01-22 01:39:22]

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/add_startup_page_overlay.html (right):

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/add_startup_page_overlay.html:11: <span
class="action-area-left"></span>
On 2011/01/22 00:48:05, stuartmorgan wrote:
> The empty element shouldn't be necessary everywhere if you add
> box-direction:reverse to action-area

Fixed, though using design per off-list.

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/add_startup_page_overlay.html:12: <span>
On 2011/01/22 00:48:05, stuartmorgan wrote:
> Span is an inline element; this should be div.

Done.

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_address_overlay.html:64: <div
class="table">
On 2011/01/22 00:48:05, stuartmorgan wrote:
> I know this is pre-existing but... why have we completely re-invented all the
> table elements as classes? If this is conceptually a table, why not use a
table?

Because tables suck.

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/language_add_language_overlay.html
(right):

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/language_add_language_overlay.html:10: <div
id="add-language-content-area" class="content-area">
On 2011/01/22 00:48:05, stuartmorgan wrote:
> Instead of adding the id just for CSS, make the rule:
> #add-language-overlay-page .content-area

Done.

[stuartmorgan, 2011-01-24 17:04:49]

LGTM with some nits.

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6372010/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_address_overlay.html:64: <div
class="table">
On 2011/01/22 01:39:22, James Hawkins wrote:
> Because tables suck.

I'm not aware of any reason tables suck for structurally tabular data... we can
talk about this offline since it's out of scope though.

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
File chrome/browser/resources/options/clear_browser_data_overlay.html (right):

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
chrome/browser/resources/options/clear_browser_data_overlay.html:42: <span
id="action-area-left">
Change to <div>

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
chrome/browser/resources/options/clear_browser_data_overlay.html:46: <span>
Same

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:106: display: -webkit-box;
Why do we need this?

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:110: display: -webkit-box;
And this?

[James Hawkins, 2011-01-24 18:42:26]

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
File chrome/browser/resources/options/clear_browser_data_overlay.html (right):

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
chrome/browser/resources/options/clear_browser_data_overlay.html:42: <span
id="action-area-left">
On 2011/01/24 17:04:49, stuartmorgan wrote:
> Change to <div>

Done.

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
chrome/browser/resources/options/clear_browser_data_overlay.html:46: <span>
On 2011/01/24 17:04:49, stuartmorgan wrote:
> Same

Done.

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:106: display: -webkit-box;
On 2011/01/24 17:04:49, stuartmorgan wrote:
> Why do we need this?

Turns out this class is not needed at all.

http://codereview.chromium.org/6372010/diff/9001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:110: display: -webkit-box;
On 2011/01/24 17:04:49, stuartmorgan wrote:
> And this?

Per off-line, the layout is incorrect w/out this.