chrome/browser/resources/options/add_startup_page_overlay.html - Issue 6372010: DOMUI: Refactor the new overlay style and apply it to all overlays.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/add_startup_page_overlay.html

Issue 6372010: DOMUI: Refactor the new overlay style and apply it to all overlays. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/browser/resources/options/autofill_edit_address_overlay.html » ('j') | chrome/browser/resources/options/autofill_edit_address_overlay.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div class="page hidden" id="addStartupPageOverlay">	1 <div class="page hidden" id="addStartupPageOverlay">

2 <h1 i18n-content="addStartupPageTitle"></h1>	2 <h1 i18n-content="addStartupPageTitle"></h1>

3

4 <form id="addStartupPageForm">	3 <form id="addStartupPageForm">

5 <label id="addURLBlock"><span	4 <div class="content-area">

6 i18n-content="addStartupPageURLLabel"></span>	5 <label id="addURLBlock"><span

7 <input type="url" id="addStartupPageURL"></label>	6 i18n-content="addStartupPageURLLabel"></span>

8	7 <input type="url" id="addStartupPageURL"></label>

9 <list id="addStartupRecentPageList"></list>	8 <list id="addStartupRecentPageList"></list>

10	9 </div>

11 <div class="action-area button-strip">	10 <div class="action-area">

12 <button type="reset"	11 <span class="action-area-left"></span>
	stuartmorgan 2011/01/22 00:48:05 The empty element shouldn't be necessary everywher The empty element shouldn't be necessary everywhere if you add box-direction:reverse to action-area James Hawkins 2011/01/22 01:39:22 Fixed, though using design per off-list. Show quoted text On 2011/01/22 00:48:05, stuartmorgan wrote: > The empty element shouldn't be necessary everywhere if you add > box-direction:reverse to action-area Fixed, though using design per off-list.
13 i18n-content="addStartupPageCancelButton"></button>	12 <span>
	stuartmorgan 2011/01/22 00:48:05 Span is an inline element; this should be div. Span is an inline element; this should be div. James Hawkins 2011/01/22 01:39:22 Done. Show quoted text On 2011/01/22 00:48:05, stuartmorgan wrote: > Span is an inline element; this should be div. Done.
14 <button type="submit" id="addStartupPageAddButton" disabled	13 <div class="button-strip">

15 i18n-content="addStartupPageAddButton"></button>	14 <button type="reset"

	15 i18n-content="addStartupPageCancelButton"></button>

	16 <button type="submit" id="addStartupPageAddButton" disabled

	17 i18n-content="addStartupPageAddButton"></button>

	18 </div>

	19 </span>

16 </div>	20 </div>

17 </form>	21 </form>

18 </div>	22 </div>

OLD	NEW