Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 999963003: Add base LayoutStyle parameter to createAnimatableValueSnapshot() (Closed)

Created:
5 years, 9 months ago by alancutter (OOO until 2018)
Modified:
5 years, 9 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, Steve Block, Timothy Loh
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add base LayoutStyle parameter to createAnimatableValueSnapshot() This patch has no behavioural changes. This change allows for an arbitrary LayoutStyle to be used as the context style when snapshotting AnimatableValues. This is in preparation for using StringKeyframes in CSS Animations (https://codereview.chromium.org/948583003). CSS Animations that start on the first frame in style resolve still have the current LayoutStyle in a temporary variable instead of in the element. This needs to be passed though to createAnimatableValueSnapshot() to ensure the AnimatableValues are resolved correctly for dependent values like inherit or 20em. BUG=361948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191846

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -37 lines) Patch
M Source/core/animation/EffectInput.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/animation/InterpolationEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolationEffect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/Keyframe.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
alancutter (OOO until 2018)
5 years, 9 months ago (2015-03-12 09:22:43 UTC) #2
dstockwell
lgtm
5 years, 9 months ago (2015-03-13 02:43:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999963003/1
5 years, 9 months ago (2015-03-13 02:48:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/47201)
5 years, 9 months ago (2015-03-13 03:41:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999963003/20001
5 years, 9 months ago (2015-03-13 08:21:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/29308)
5 years, 9 months ago (2015-03-13 09:15:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999963003/20001
5 years, 9 months ago (2015-03-13 12:37:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999963003/40001
5 years, 9 months ago (2015-03-13 12:49:51 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 15:34:34 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191846

Powered by Google App Engine
This is Rietveld 408576698