Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 999963002: Fix system_stub.Restore(), and add a unittest to catch the bug being fixed. (Closed)

Created:
5 years, 9 months ago by aiolos (Not reviewing)
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, dtu, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix system_stub.Restore(), and add a unittest to catch the bug being fixed. BUG=466415 Committed: https://crrev.com/c12ba21289ad8a745e5526e547a78d92ab309ca8 Cr-Commit-Position: refs/heads/master@{#320385}

Patch Set 1 #

Total comments: 2

Patch Set 2 : More obvious unittest #

Total comments: 1

Patch Set 3 : Add comment to Restore(). #

Patch Set 4 : Added Copyright info for Chromium presubmit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M tools/telemetry/telemetry/unittest_util/system_stub.py View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/system_stub_unittest.py View 1 2 chunks +13 lines, -1 line 0 comments Download
A + tools/telemetry/unittest_data/system_stub_test_module.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
aiolos (Not reviewing)
5 years, 9 months ago (2015-03-12 00:15:35 UTC) #2
Dirk Pranke
lgtm, with comments below. https://codereview.chromium.org/999963002/diff/1/tools/telemetry/telemetry/unittest_util/system_stub_unittest.py File tools/telemetry/telemetry/unittest_util/system_stub_unittest.py (right): https://codereview.chromium.org/999963002/diff/1/tools/telemetry/telemetry/unittest_util/system_stub_unittest.py#newcode227 tools/telemetry/telemetry/unittest_util/system_stub_unittest.py:227: system_stub_test_module.SystemStubTest.TestOpen(file_path) I assume you're testing ...
5 years, 9 months ago (2015-03-12 00:26:29 UTC) #3
aiolos (Not reviewing)
https://codereview.chromium.org/999963002/diff/1/tools/telemetry/telemetry/unittest_util/system_stub_unittest.py File tools/telemetry/telemetry/unittest_util/system_stub_unittest.py (right): https://codereview.chromium.org/999963002/diff/1/tools/telemetry/telemetry/unittest_util/system_stub_unittest.py#newcode227 tools/telemetry/telemetry/unittest_util/system_stub_unittest.py:227: system_stub_test_module.SystemStubTest.TestOpen(file_path) On 2015/03/12 00:26:29, Dirk Pranke wrote: > I ...
5 years, 9 months ago (2015-03-12 19:01:16 UTC) #4
sullivan
lgtm https://codereview.chromium.org/999963002/diff/20001/tools/telemetry/telemetry/unittest_util/system_stub.py File tools/telemetry/telemetry/unittest_util/system_stub.py (right): https://codereview.chromium.org/999963002/diff/20001/tools/telemetry/telemetry/unittest_util/system_stub.py#newcode52 tools/telemetry/telemetry/unittest_util/system_stub.py:52: if original_module is None: Would be good to ...
5 years, 9 months ago (2015-03-12 19:51:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999963002/40001
5 years, 9 months ago (2015-03-12 20:26:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999963002/40002
5 years, 9 months ago (2015-03-12 20:47:47 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:40002)
5 years, 9 months ago (2015-03-12 22:05:35 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 22:06:43 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c12ba21289ad8a745e5526e547a78d92ab309ca8
Cr-Commit-Position: refs/heads/master@{#320385}

Powered by Google App Engine
This is Rietveld 408576698