Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issue 999953003: Remove dedicated TextCodecUTF16 (Closed)

Created:
5 years, 9 months ago by jsbell
Modified:
5 years, 3 months ago
Reviewers:
jungshik at Google
CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove dedicated TextCodecUTF16 Just rely on ICU for UTF-16LE/BE. This fixes some bugs related to state handling when decoding chunks with an odd number of bytes. It also removes non-standard special cases for end-of-stream handling. BUG=468927, 368904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -282 lines) Patch
D LayoutTests/fast/encoding/api/utf16-surrogates-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M LayoutTests/fast/encoding/char-decoding-truncated.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/encoding/char-decoding-truncated-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/encoding/utf-16-odd-byte-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/TextCodecICU.cpp View 2 chunks +12 lines, -1 line 0 comments Download
D Source/wtf/text/TextCodecUTF16.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/wtf/text/TextCodecUTF16.cpp View 1 chunk +0 lines, -190 lines 0 comments Download
M Source/wtf/text/TextEncoding.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/wtf/text/TextEncodingRegistry.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jsbell
jshin@ - I don't think we should land this as-is, and I think the removal ...
5 years, 9 months ago (2015-03-19 20:58:18 UTC) #2
jungshik at Google
On 2015/03/19 20:58:18, jsbell wrote: > jshin@ - I don't think we should land this ...
5 years, 9 months ago (2015-03-20 17:54:14 UTC) #3
jsbell
5 years, 3 months ago (2015-09-23 17:32:23 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698