Use LockFile/UnlockFile for Settings to port to Windows

util/misc/uuid.h

Index: util/misc/uuid.h
diff --git a/util/misc/uuid.h b/util/misc/uuid.h
index 29b36bc09b8c8c26ded6dd6e63effa7d23b5fb87..41bd0bef4079b9dfadb7111ea3bfcd7fbb5a1e16 100644
--- a/util/misc/uuid.h
+++ b/util/misc/uuid.h
@@ -84,6 +84,9 @@ struct UUID {
   base::string16 ToString16() const;
 #endif  // OS_WIN
 
+  //! \brief Uses a standard system facility to generate a new UUID.
+  static bool GenerateFromSystem(UUID* into);

[Mark Mentovai, 2015/04/01 21:15:19]

Thank you for doing this! It’s been on my list catch-up cleanups to do.

I don’t see why this should be a static method. We should have a non-static
InitializeWithNew() or something that does this.

We may also want a constructor mode that does InitializeWithNew() instead of
giving a zero UUID.

[scottmg, 2015/04/01 21:51:37]

Done. I didn't add the constructor mode as UuidCreate has a failure mode on
Windows, so the caller should deal with that.

+
   // These fields are laid out according to RFC 4122 §4.1.2.
   uint32_t data_1;
   uint16_t data_2;