Use LockFile/UnlockFile for Settings to port to Windows

client/settings_test.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "client/settings.h"
 
 #include "gtest/gtest.h"
+#include "test/errors.h"
 #include "test/scoped_temp_dir.h"
 #include "util/file/file_io.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 class SettingsTest : public testing::Test {
  public:
   SettingsTest() : settings_(settings_path()) {}
 
   base::FilePath settings_path() {
-    return temp_dir_.path().Append("settings");
+    return temp_dir_.path().Append(FILE_PATH_LITERAL("settings"));
   }
 
   Settings* settings() { return &settings_; }
 
   void InitializeBadFile() {
     ScopedFileHandle handle(
         LoggingOpenFileForWrite(settings_path(),
                                 FileWriteMode::kTruncateOrCreate,
                                 FilePermissions::kWorldReadable));
     ASSERT_TRUE(handle.is_valid());
@@ skipping 103 matching lines @@
   EXPECT_TRUE(settings()->GetUploadsEnabled(&enabled));
   EXPECT_TRUE(enabled);
 }
 
 TEST_F(SettingsTest, UnlinkFile) {
   UUID client_id;
   EXPECT_TRUE(settings()->GetClientID(&client_id));
   EXPECT_TRUE(settings()->SetUploadsEnabled(true));
   EXPECT_TRUE(settings()->SetLastUploadAttemptTime(time(nullptr)));
 
-  EXPECT_EQ(0, unlink(settings_path().value().c_str()));
+#if defined(OS_WIN)
+  EXPECT_EQ(0, _wunlink(settings_path().value().c_str()));

[Robert Sesek, 2015/04/01 15:08:26]

Log the message, like for POSIX?

[scottmg, 2015/04/01 19:32:10]

Done.

+#else
+  EXPECT_EQ(0, unlink(settings_path().value().c_str()))
+      << ErrnoMessage("unlink");
+#endif
 
   Settings local_settings(settings_path());
   EXPECT_TRUE(local_settings.Initialize());
   UUID new_client_id;
   EXPECT_TRUE(local_settings.GetClientID(&new_client_id));
   EXPECT_NE(client_id, new_client_id);
 
   // Check that all values are reset.
   bool enabled = true;
   EXPECT_TRUE(local_settings.GetUploadsEnabled(&enabled));
   EXPECT_FALSE(enabled);
 
   time_t time = -1;
   EXPECT_TRUE(local_settings.GetLastUploadAttemptTime(&time));
   EXPECT_EQ(0, time);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad