Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 999933010: Run chromium_trybot based Cast bots at 10%. (Closed)

Created:
5 years, 9 months ago by gunsch
Modified:
5 years, 9 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run chromium_trybot based Cast bots at 10%. R=sergeyberezin@chromium.org BUG=468335 Committed: https://crrev.com/02dd0e6986155a821c2544ad338235e12b9e4f80 Cr-Commit-Position: refs/heads/master@{#322454}

Patch Set 1 #

Patch Set 2 : alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M testing/commit_queue/config.json View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
gunsch
5 years, 9 months ago (2015-03-26 18:23:44 UTC) #1
Sergey Berezin
LGTM. FTR, I'm not the best reviewer for CQ configs anymore; please use other owners ...
5 years, 9 months ago (2015-03-26 19:20:01 UTC) #2
gunsch
On 2015/03/26 19:20:01, Sergey Berezin wrote: > LGTM. > > FTR, I'm not the best ...
5 years, 9 months ago (2015-03-26 19:46:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999933010/20001
5 years, 9 months ago (2015-03-26 19:47:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 20:10:39 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/02dd0e6986155a821c2544ad338235e12b9e4f80 Cr-Commit-Position: refs/heads/master@{#322454}
5 years, 9 months ago (2015-03-26 20:11:41 UTC) #7
jam
I just saw this. I have a question about cast_shell. Why does it run tests ...
5 years, 9 months ago (2015-03-26 20:17:12 UTC) #8
gunsch
5 years, 9 months ago (2015-03-26 20:26:34 UTC) #9
Message was sent while issue was closed.
On 2015/03/26 20:17:12, jam wrote:
> I just saw this. I have a question about cast_shell. Why does it run tests
> suites like
>
base_unittests/cacheinvalidation_unittests/content_unittests/crypto_unittests/gpu_unittests/ipc_tests/jingle_unittests/media_unittests/net_unittests/sandbox_linux_unittests/sql_unittests/sync_unit_tests/ui_base_unittests/url_unittests?
> cast is just an embedder of content, so it can't affect these test targets,
no?

Chromecast sets a number of GYP flags that other build variants don't, which
affects how the rest of Chromium gets built. More often than not, the build
breakages we see are due to things that don't affect src/chromecast/ or the APIs
it directly consumes, but rather other Chromium code within the build
configuration that we use.

Powered by Google App Engine
This is Rietveld 408576698