Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 999923004: Cleanup and unify Isolate::ReportPendingMessages. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_stack-handler-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup and unify Isolate::ReportPendingMessages. Note that this is a pure cleanup CL and shouldn't have an observable impact on the functional behavior of message reporting. R=yangguo@chromium.org

Patch Set 1 #

Patch Set 2 : Fix comment. #

Patch Set 3 : Rebased. #

Patch Set 4 : Simplify further. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -59 lines) Patch
M src/isolate.h View 1 2 chunks +4 lines, -6 lines 0 comments Download
M src/isolate.cc View 1 2 3 4 chunks +37 lines, -53 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-13 14:59:13 UTC) #1
Yang
On 2015/03/13 14:59:13, Michael Starzinger wrote: Nice! LGTM if tests pass.
5 years, 9 months ago (2015-03-13 15:06:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999923004/60001
5 years, 9 months ago (2015-03-18 13:57:23 UTC) #5
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a8865b3bb1b30369051a7a305a1d09b746b23aad Cr-Commit-Position: refs/heads/master@{#27276}
5 years, 9 months ago (2015-03-18 15:59:58 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-18 16:02:02 UTC) #7
Michael Achenbach
Is it possible that this changed: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Mac/builds/2510 http://build.chromium.org/p/client.v8/builders/V8-Blink%20Win/builds/2653 Tests: plugins/netscape-plugin-property-access-exception.html http/tests/plugins/cross-frame-object-access.html The problems are persistent ...
5 years, 9 months ago (2015-03-19 00:16:31 UTC) #9
Michael Achenbach
Triggered a test here: https://codereview.chromium.org/1020733002/
5 years, 9 months ago (2015-03-19 01:53:30 UTC) #10
Michael Starzinger
5 years, 9 months ago (2015-03-19 13:22:24 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1016323002/ by mstarzinger@chromium.org.

The reason for reverting is: Failing Blink tests on Win and Mac:
- plugins/netscape-plugin-property-access-exception.html
- http/tests/plugins/cross-frame-object-access.html.

Powered by Google App Engine
This is Rietveld 408576698