Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 9999035: Add DCHECK to ensure IndexedDBDispatcher doesn't get re-created. (Closed)

Created:
7 years, 5 months ago by dgrogan
Modified:
7 years, 5 months ago
Reviewers:
michaeln
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jsbell
Visibility:
Public.

Description

Add DCHECK to ensure IndexedDBDispatcher doesn't get re-created. This could happen if there are IDB objects that survive the call to didStopWorkerRunLoop. BUG=121734 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/common/indexed_db/indexed_db_dispatcher.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrogan
Michael, could you review this?
7 years, 5 months ago (2012-04-10 20:57:20 UTC) #1
michaeln
lgtm When you run the repro is that really NOTREACHED()?
7 years, 5 months ago (2012-04-10 21:18:49 UTC) #2
dgrogan
Yeah, with the repro the NOTREACHED is not reached. We'll see what happens on the ...
7 years, 5 months ago (2012-04-10 21:39:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9999035/1
7 years, 5 months ago (2012-04-10 21:39:57 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2012-04-11 00:08:02 UTC) #5
Change committed as 131679

Powered by Google App Engine
This is Rietveld 408576698