Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: src/scopes.h

Issue 999893003: Modules: simplify logic around allocation of module internal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/scopes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_SCOPES_H_ 5 #ifndef V8_SCOPES_H_
6 #define V8_SCOPES_H_ 6 #define V8_SCOPES_H_
7 7
8 #include "src/ast.h" 8 #include "src/ast.h"
9 #include "src/pending-compilation-error-handler.h" 9 #include "src/pending-compilation-error-handler.h"
10 #include "src/zone.h" 10 #include "src/zone.h"
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 bool MustAllocateInContext(Variable* var); 685 bool MustAllocateInContext(Variable* var);
686 bool HasArgumentsParameter(Isolate* isolate); 686 bool HasArgumentsParameter(Isolate* isolate);
687 687
688 // Variable allocation. 688 // Variable allocation.
689 void AllocateStackSlot(Variable* var); 689 void AllocateStackSlot(Variable* var);
690 void AllocateHeapSlot(Variable* var); 690 void AllocateHeapSlot(Variable* var);
691 void AllocateParameterLocals(Isolate* isolate); 691 void AllocateParameterLocals(Isolate* isolate);
692 void AllocateNonParameterLocal(Isolate* isolate, Variable* var); 692 void AllocateNonParameterLocal(Isolate* isolate, Variable* var);
693 void AllocateNonParameterLocals(Isolate* isolate); 693 void AllocateNonParameterLocals(Isolate* isolate);
694 void AllocateVariablesRecursively(Isolate* isolate); 694 void AllocateVariablesRecursively(Isolate* isolate);
695 void AllocateModulesRecursively(Scope* host_scope); 695 void AllocateModules();
696 696
697 // Resolve and fill in the allocation information for all variables 697 // Resolve and fill in the allocation information for all variables
698 // in this scopes. Must be called *after* all scopes have been 698 // in this scopes. Must be called *after* all scopes have been
699 // processed (parsed) to ensure that unresolved variables can be 699 // processed (parsed) to ensure that unresolved variables can be
700 // resolved properly. 700 // resolved properly.
701 // 701 //
702 // In the case of code compiled and run using 'eval', the context 702 // In the case of code compiled and run using 'eval', the context
703 // parameter is the context in which eval was called. In all other 703 // parameter is the context in which eval was called. In all other
704 // cases the context parameter is an empty handle. 704 // cases the context parameter is an empty handle.
705 MUST_USE_RESULT 705 MUST_USE_RESULT
(...skipping 21 matching lines...) Expand all
727 727
728 AstValueFactory* ast_value_factory_; 728 AstValueFactory* ast_value_factory_;
729 Zone* zone_; 729 Zone* zone_;
730 730
731 PendingCompilationErrorHandler pending_error_handler_; 731 PendingCompilationErrorHandler pending_error_handler_;
732 }; 732 };
733 733
734 } } // namespace v8::internal 734 } } // namespace v8::internal
735 735
736 #endif // V8_SCOPES_H_ 736 #endif // V8_SCOPES_H_
OLDNEW
« no previous file with comments | « no previous file | src/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698