Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 999893003: Modules: simplify logic around allocation of module internal variables (Closed)

Created:
5 years, 9 months ago by adamk
Modified:
5 years, 9 months ago
CC:
v8-dev, Dmitry Lomov (no reviews)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Modules: simplify logic around allocation of module internal variables Since recursive modules are gone, only the top-level scope can have module inner scopes. Rename Scope::AllocateModulesRecursively to Scope::AllocateModules, and add test showing the module Variables are still allocated appropriately in the top level scope. BUG=v8:1569, v8:3940 LOG=n Committed: https://crrev.com/9703c057c504a2dcc202e07d027919a566630ae6 Cr-Commit-Position: refs/heads/master@{#27143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M src/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
adamk
5 years, 9 months ago (2015-03-11 22:16:49 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 9 months ago (2015-03-11 22:47:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999893003/1
5 years, 9 months ago (2015-03-11 22:50:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1167)
5 years, 9 months ago (2015-03-11 22:57:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999893003/1
5 years, 9 months ago (2015-03-11 22:59:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 23:19:51 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 23:20:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9703c057c504a2dcc202e07d027919a566630ae6
Cr-Commit-Position: refs/heads/master@{#27143}

Powered by Google App Engine
This is Rietveld 408576698