Profiler-instrumentation of the startup time.

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stdlib.h>
 
 #include "base/allocator/allocator_extension.h"
 #include "base/at_exit.h"
@@ skipping 550 matching lines @@
 
 #if !defined(OS_WIN)
     argc = params.argc;
     argv = params.argv;
 #endif
 
     base::CommandLine::Init(argc, argv);
 
     base::EnableTerminationOnHeapCorruption();
 
+    // Enable profiler recording right after command line is initialized.
+    delegate_->EnableProfilerRecording();

[vadimt, 2015/03/12 18:23:03]

Please move this call to BrowserMainRunnerImpl::Initialize.

[yao, 2015/03/12 18:32:19]

This place runs earlier than that. we may want to intrument code that's earlier
than BrowserMainRunnerImpl::Initialize? do we? 

[vadimt, 2015/03/12 18:37:26]

Unlikely. But we'll benefit from not spreading this logic across multiple
places. Putting everything together will make it easier to understand and clean
up code.

(This is a strong opinion :) )

[yao, 2015/03/13 14:28:31]

I see. 

But this function takes in ContentMainParams, which has delegate as one of the
params. However, the function you are suggesting takes in MainFunctionParams and
it doesn't not have that delegate any more. 

[vadimt, 2015/03/13 14:32:58]

Then it's OK to leave it here. Please mark ALL added code with the comment to
remove it after crbug.com/453640 is fixed.

[yao, 2015/03/13 15:24:49]

Done.

+
 #if !defined(OS_IOS)
     SetProcessTitleFromCommandLine(argv);
 #endif
 #endif // !OS_ANDROID
 
     int exit_code = 0;
     if (delegate_ && delegate_->BasicStartupComplete(&exit_code))
       return exit_code;
 
     completed_basic_startup_ = true;
@@ skipping 245 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content