Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 999833002: Allow dynamic change to WebRTC's multiple_routes_enabled preference. (Closed)

Created:
5 years, 9 months ago by guoweis_left_chromium
Modified:
5 years, 9 months ago
Reviewers:
juberti2, battre
CC:
chromium-reviews, msramek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow dynamic change to WebRTC's multiple_routes_enabled preference. Currently, this preference is not monitored such that any change through the extension api will require a restart of chrome. landed fix for crbug.com/457629 is to expose extension api to allow this be changed dynamically. Tested with the extension. BUG=466197 Committed: https://crrev.com/3e1269e6e3950185ff3cc791faff3781acc24064 Cr-Commit-Position: refs/heads/master@{#320134}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
guoweis_left_chromium
PTAL.
5 years, 9 months ago (2015-03-11 17:35:22 UTC) #3
battre
lgtm
5 years, 9 months ago (2015-03-11 17:44:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999833002/20001
5 years, 9 months ago (2015-03-11 18:15:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999833002/20001
5 years, 9 months ago (2015-03-11 20:23:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 20:24:33 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 20:26:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e1269e6e3950185ff3cc791faff3781acc24064
Cr-Commit-Position: refs/heads/master@{#320134}

Powered by Google App Engine
This is Rietveld 408576698