Make sure that WaitableEvent::TimedWait works fine with large timeouts.

Make sure that WaitableEvent::TimedWait works fine with large timeouts.

TimedWait(TimeDelta::Max()) should do the same as Wait() (although should not
be used, given that there is a dedicated method to do that).

More generally, TimedWait should accept random, unreasonable large timeouts.

BUG=465948
TESTS=base_unittests

Committed: https://crrev.com/ac3c7563ee4a116ec66cbec8679afc9ec1a61da4
Cr-Commit-Position: refs/heads/master@{#322469}

[rvargas (doing something else), 2015-03-24 02:20:03]

Patchset #1 (id:1) has been deleted

[rvargas (doing something else), 2015-03-24 19:21:20]

rvargas@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-03-25 01:36:27]

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
File base/synchronization/waitable_event_posix.cc (right):

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
base/synchronization/waitable_event_posix.cc:159: DCHECK(max_time >=
TimeDelta());
Can we use DCHECK_GE() in both impls?

Also mention this in the header.

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
File base/synchronization/waitable_event_unittest.cc (right):

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
base/synchronization/waitable_event_unittest.cc:87: TimeDelta delay_;
nit: can this stay const since it doesn't change?

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
base/synchronization/waitable_event_unittest.cc:92: // additional
synchrnization.
nit: typo (cut+pasted), ditto below.

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
base/synchronization/waitable_event_unittest.cc:143: TimeTicks
end_time(TimeTicks::Now() + TimeDelta::Max());
I can't tell what part this plays in the test. Should it be in
base/time/time_unittest.cc instead?

[rvargas (doing something else), 2015-03-26 19:37:29]

Thanks!

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
File base/synchronization/waitable_event_posix.cc (right):

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
base/synchronization/waitable_event_posix.cc:159: DCHECK(max_time >=
TimeDelta());
On 2015/03/25 01:36:27, Lei Zhang wrote:
> Can we use DCHECK_GE() in both impls?
> 
> Also mention this in the header.

Done.

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
File base/synchronization/waitable_event_unittest.cc (right):

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
base/synchronization/waitable_event_unittest.cc:87: TimeDelta delay_;
On 2015/03/25 01:36:27, Lei Zhang wrote:
> nit: can this stay const since it doesn't change?

Done.

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
base/synchronization/waitable_event_unittest.cc:92: // additional
synchrnization.
On 2015/03/25 01:36:27, Lei Zhang wrote:
> nit: typo (cut+pasted), ditto below.

Done.

https://codereview.chromium.org/999753005/diff/20001/base/synchronization/wai...
base/synchronization/waitable_event_unittest.cc:143: TimeTicks
end_time(TimeTicks::Now() + TimeDelta::Max());
On 2015/03/25 01:36:27, Lei Zhang wrote:
> I can't tell what part this plays in the test. Should it be in
> base/time/time_unittest.cc instead?

Sorry, this was a quick test I did weeks ago before filing bug 466445 and forgot
it was here :(

Removed.

[Lei Zhang, 2015-03-26 20:54:48]

lgtm

[rvargas (doing something else), 2015-03-26 20:57:41]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2015-03-26 20:58:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/999753005/40001

[commit-bot: I haz the power, 2015-03-26 21:12:38]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-26 21:15:23]

Patchset 2 (id:??) landed as
https://crrev.com/ac3c7563ee4a116ec66cbec8679afc9ec1a61da4
Cr-Commit-Position: refs/heads/master@{#322469}