Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 999653002: [Smart Lock] Add error strings to show when the phone's software is out of date. (Closed)

Created:
5 years, 9 months ago by Ilya Sherman
Modified:
5 years, 9 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Add error strings to show when the phone's software is out of date. BUG=453998 TEST=none R=tengs@chromium.org Committed: https://crrev.com/0bce0909af433749f5e0b7df833313f2a53c2ec0 Cr-Commit-Position: refs/heads/master@{#320162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ilya Sherman
5 years, 9 months ago (2015-03-11 02:45:23 UTC) #1
Tim Song
lgtm
5 years, 9 months ago (2015-03-11 19:46:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999653002/1
5 years, 9 months ago (2015-03-11 19:54:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 22:12:00 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 22:12:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bce0909af433749f5e0b7df833313f2a53c2ec0
Cr-Commit-Position: refs/heads/master@{#320162}

Powered by Google App Engine
This is Rietveld 408576698