Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 99963007: Disable GN in gyp_chromium. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Disable GN in gyp_chromium. Android is still broken: https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/23775/steps/runhooks/logs/stdio ERROR at the command-line "--gyp_vars":1:29: Invalid token. data_reduction_fallback_host%="http://compress.googlezip.net:80/" app_manifest_version_name="clang-clankium-tot-builder 33.0.1728.0" gcc_version="46" app_manifest_version_code="1728000" data_reduction_proxy_probe_url%="http://check.googlezip.net/connect" host_os="linux" component="shared_library" clang="1" spdy_proxy_auth_origin%="https://proxy.googlezip.net:443/" order_text_section="/b/build/slave/clang-clankium-tot-builder/build/src/orderfiles/orderfile.out" spdy_proxy_auth_value%="3c1d997267c567617ffe0e1b1ebbeed71398dd27" target_arch="arm" chrome_build_id="none" fastbuild="1" OS="android" android_app_targets="['../clank/native/framework/clank.gyp:clank', '../clank/native/framework/clank.gyp:devtools_resources', '../clank/native/framework/clank.gyp:chrome_test_apk', '../clank/java/geppetto/uiautomator.gyp:chrome_uiautomator_tests']"  ^ I have no idea what this is. Generating gyp files from GN... < gclient runhooks ERROR: process exited with code 2 @@@STEP_FAILURE@@@ FATAL 2 != 88 BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
build/gyp_chromium View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
lgtm
7 years ago (2013-12-04 01:21:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/99963007/1
7 years ago (2013-12-04 01:24:39 UTC) #2
commit-bot: I haz the power
7 years ago (2013-12-04 01:28:48 UTC) #3
Message was sent while issue was closed.
Change committed as 238519

Powered by Google App Engine
This is Rietveld 408576698