Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: components/metrics/proto/system_profile.proto

Issue 999623002: metrics/base: log whether drives have seek penalties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/proto/system_profile.proto
diff --git a/components/metrics/proto/system_profile.proto b/components/metrics/proto/system_profile.proto
index c73d8a95e8086a6bf9935297078e354ed3a48dd0..ef7a4ede843105d5bb2b0293b478995eb1e7cc80 100644
--- a/components/metrics/proto/system_profile.proto
+++ b/components/metrics/proto/system_profile.proto
@@ -92,7 +92,7 @@ message SystemProfileProto {
}
optional OS os = 5;
- // Next tag for Hardware: 16
+ // Next tag for Hardware: 18
// Information on the user's hardware.
message Hardware {
// The CPU architecture (x86, PowerPC, x86_64, ...)
@@ -261,6 +261,14 @@ message SystemProfileProto {
// Lists vendor and product ids of external touchscreens.
// Logged on ChromeOS only.
repeated TouchScreen external_touchscreen = 15;
+
+ message Disk {
Alexei Svitkine (slow) 2015/03/12 16:41:06 Is Disk the right terminology here or should we us
Dan Beam 2015/03/13 19:31:32 I originally did this to avoid confusion with Goog
+ optional bool has_seek_penalty = 1;
+ }
+ // The disk that Chrome loads from.
Alexei Svitkine (slow) 2015/03/12 16:41:06 Nit: "Chrome" -> "the application". (as this proto
Dan Beam 2015/03/13 19:31:32 Done.
+ optional Disk app_disk = 16;
+ // The disk that the current --user-data-dir loads from.
+ optional Disk user_data_disk = 17;
}
optional Hardware hardware = 6;
« chrome/browser/metrics/disk_metrics_provider.cc ('K') | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698