Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3337)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 999623002: metrics/base: log whether drives have seek penalties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DONT_ASSERT_ANYTHING Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 8954197117c9b35a4d1ba0d4a5d44bf6d59bf963..e8b87594a2bba10f75b970b8d50e8057894f3e78 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -22,6 +22,7 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/google/google_brand.h"
#include "chrome/browser/metrics/chrome_stability_metrics_provider.h"
+#include "chrome/browser/metrics/drive_metrics_provider.h"
#include "chrome/browser/metrics/omnibox_metrics_provider.h"
#include "chrome/browser/ui/browser_otr_state.h"
#include "chrome/common/chrome_constants.h"
@@ -103,9 +104,17 @@ metrics::SystemProfileProto::Channel AsProtobufChannel(
ChromeMetricsServiceClient::ChromeMetricsServiceClient(
metrics::MetricsStateManager* state_manager)
: metrics_state_manager_(state_manager),
- chromeos_metrics_provider_(NULL),
+ chromeos_metrics_provider_(nullptr),
waiting_for_collect_final_metrics_step_(false),
num_async_histogram_fetches_in_progress_(0),
+ profiler_metrics_provider_(nullptr),
+#if defined(ENABLE_PLUGINS)
+ plugin_metrics_provider_(nullptr),
+#endif
+#if defined(OS_WIN)
+ google_update_metrics_provider_(nullptr),
+#endif
+ drive_metrics_provider_(nullptr),
weak_ptr_factory_(this) {
DCHECK(thread_checker_.CalledOnValidThread());
RecordCommandLineMetrics();
@@ -286,7 +295,11 @@ void ChromeMetricsServiceClient::Initialize() {
metrics_service_->RegisterMetricsProvider(
scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider));
metrics_service_->RegisterMetricsProvider(
- scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider()));
+ scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider));
+
+ drive_metrics_provider_ = new DriveMetricsProvider;
+ metrics_service_->RegisterMetricsProvider(
+ scoped_ptr<metrics::MetricsProvider>(drive_metrics_provider_));
profiler_metrics_provider_ =
new metrics::ProfilerMetricsProvider(cellular_callback);
@@ -384,7 +397,8 @@ void ChromeMetricsServiceClient::ReceivedProfilerData(
}
void ChromeMetricsServiceClient::FinishedReceivingProfilerData() {
- finished_gathering_initial_metrics_callback_.Run();
+ drive_metrics_provider_->GetDriveMetrics(
+ finished_gathering_initial_metrics_callback_);
}
void ChromeMetricsServiceClient::OnMemoryDetailCollectionDone() {
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/metrics/drive_metrics_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698