metrics/base: log whether drives have seek penalties.

components/metrics/proto/system_profile.proto

Index: components/metrics/proto/system_profile.proto
diff --git a/components/metrics/proto/system_profile.proto b/components/metrics/proto/system_profile.proto
index c73d8a95e8086a6bf9935297078e354ed3a48dd0..1aec333bd74860b402ee5e209ce1fc65e0172e25 100644
--- a/components/metrics/proto/system_profile.proto
+++ b/components/metrics/proto/system_profile.proto
@@ -92,7 +92,7 @@ message SystemProfileProto {
   }
   optional OS os = 5;
 
-  // Next tag for Hardware: 16
+  // Next tag for Hardware: 18
   // Information on the user's hardware.
   message Hardware {
     // The CPU architecture (x86, PowerPC, x86_64, ...)
@@ -261,6 +261,14 @@ message SystemProfileProto {
     // Lists vendor and product ids of external touchscreens.
     // Logged on ChromeOS only.
     repeated TouchScreen external_touchscreen = 15;
+
+    message Drive {
+      optional bool has_seek_penalty = 1;

[Alexei Svitkine (slow), 2015/03/16 16:49:36]

This definitely needs a comment.

[Dan Beam, 2015/03/16 19:20:23]

Done.

+    }
+    // The drive that the application executable was loaded from.
+    optional Drive app_drive = 16;
+    // The drive that the current --user-data-dir was loaded from.

[Alexei Svitkine (slow), 2015/03/16 16:49:36]

Nit: I would actually just say "the user data directory" rather than mention the
command-line parameter.

[Dan Beam, 2015/03/16 19:20:23]

Done.

+    optional Drive user_data_drive = 17;
   }
   optional Hardware hardware = 6;